5.2 | APIScan | MSAL WithClientName
#3359
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR backports changes to the MSAL application building code to use CreateWithApplicationOptions, avoiding the previously undocumented APIs.
- Refactors the creation of client application instances using the new builder pattern.
- Adjusts platform-specific logic using conditional compilation directives.
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Show resolved
Hide resolved
benrr101
changed the title
WithClientNameWithClientName
| return publicClientApplication; | ||
| } | ||
|
|
||
| private static TokenCredentialData CreateTokenCredentialInstance(TokenCredentialKey tokenCredentialKey, string secret) |
There was a problem hiding this comment.
Nope, I just made a mistake...
There was a problem hiding this comment.
Pull Request Overview
Backports MSAL application builder code to use CreateWithApplicationOptions and remove reliance on formerly undocumented APIs.
- Replaces chained Create(...).WithX calls with a single CreateWithApplicationOptions initializer.
- Refactors platform-specific parent-window logic into separate WithParentActivityOrWindow invocations.
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Show resolved
Hide resolved
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/5.2 #3359 +/- ##
===============================================
- Coverage 72.68% 72.59% -0.09%
===============================================
Files 310 310
Lines 61933 61930 -3
===============================================
- Hits 45013 44961 -52
- Misses 16920 16969 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description: Backporting rewriting MSAL application building code to use CreateWithApplicationOptions and avoid (formerly) undocumented APIs. See #3354 for full details of change.